search

paytonrules / OCDSpec

An awesome TDD framework for Objective-C
http://paytonrules.com/OCDSpec/
MIT License
19 stars 4 forks source link

OCDSpecExpectation Changes #14

Closed ericmeyer closed 12 years ago

ericmeyer commented 12 years ago

Added support for custom matchers and a matcher for toBeEmptyString

paytonrules commented 12 years ago

Is the failWithMessage method just a refactoring? failWithMessage doesn't have to be in the header since it's internal

ericmeyer commented 12 years ago

Definitely can't be internal if categories need to use it. At least not in the way you had it. I intentionally made a simple fail method like that public to support adding matchers via categories.

Eric

On Mar 9, 2012, at 10:07 PM, Eric Smithreply@reply.github.com wrote:

Is the failWithMessage method just a refactoring? failWithMessage doesn't have to be in the header since it's internal

Reply to this email directly or view it on GitHub: https://github.com/paytonrules/OCDSpec/pull/14#issuecomment-4428716

paytonrules commented 12 years ago

Two minor things: 1) This won't get merged for a little longer - because it' can't be merged automatically anymore. That's cause of me refactoring and bug fixing.

2) Can you add a test for failWithMessage? Since it's public I'd like to see one. I understand why it's public now.

I really like having the example in there BTW.

paytonrules commented 12 years ago

Eric were you able to do this:

2) Can you add a test for failWithMessage? Since it's public I'd like to see one. I understand why it's public now.

I don't see it but my git-hub fu is weak. Also I'm only awake cause my daughter insisted I get up at 6:15.

ericmeyer commented 12 years ago

This pull request made obsolete by new pull request.