search

paytrail / paytrail-for-adobe-commerce

Paytrail payment service for Adobe Commerce (formerly known as Magento 2)
https://www.paytrail.com
MIT License
2 stars 7 forks source link

Remove php7.x from composer.json #50

Closed juhanihaapala closed 1 year ago

juhanihaapala commented 1 year ago

Description

After version 1.4.0 module is not compatible with php 7.x versions, for example these lines throws syntax error, unexpected '|', expecting variable (T_VARIABLE) with php7.4 https://github.com/paytrail/paytrail-for-adobe-commerce/blob/master/Helper/ApiData.php#L203-L207

VuorelaJ-P commented 1 year ago

Well there's syntac error | should be || if using logical or. Though "php": ">=7.3" would work just fine. Platform requirements should never using logical or, since 8. is anyway greater than 7.3. Logical operators are useful only for dependencies avoiding breaking changes between PHP versions. Instead removing 7. I would change this >=7.3, which is same than PHP-SDK requirement, and would work any system above that.