Make get_qstat_info more robust

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems

Apache License 2.0

19 stars 26 forks source link

Make get_qstat_info more robust #195

Closed aidanheerdegen closed 4 years ago

aidanheerdegen commented 4 years ago

Added retry decorator (from tenacity) to get_qstat_info as calls to qstat were timing out and bringing down simulations with multiple runs per submit.

pep8speaks commented 4 years ago

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/scheduler/pbs.py:

Line 44:65: W291 trailing whitespace

Comment last updated at 2019-09-18 06:58:14 UTC

aidanheerdegen commented 4 years ago

@marshallward I did wonder if it was a good idea to add yet another dependency, but decided that maybe this is something that could be useful more than just in this one place, so decided to go with the tried and tested solution.

aidanheerdegen commented 4 years ago

Checked and seems to be working on raijin. Will merge as I need a fix for a user.