payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 26 forks source link

shortpath --> scratchpath #224

Closed navidcy closed 3 years ago

navidcy commented 4 years ago

shortpath is deprecated with new gadi machine. Perhaps change it to scratchpath or make a synonym to retain backwards compatibility?

navidcy commented 3 years ago

Is it time to let go of shortpath?

aidanheerdegen commented 3 years ago

I could have sworn we'd had a discussion about this already, but if we had it isn't in the issues or PRs.

I think the argument was that there were a lot of legacy configs that already use shortpath, and that it could potentially be just as confusing adding scratchpath as leaving it as-is.

navidcy commented 3 years ago

That’s why I suggested a synonym, ie both should work. Feel free to close the issue if discussion was made : )

aekiss commented 3 years ago

or maybe a neutral synonym like outputpath that's independent of whatever NCI decide to call their scratch space? Who knows what it will be called in the next machine...

navidcy commented 3 years ago

@aekiss looks ahead in the future.

aidanheerdegen commented 3 years ago

In a way shortpath is already machine agnostic, as there is no longer a /short filesystem ... the argument against change is confusion. It sort of doesn't matter what you choose as your new name, it will still be confusing that there are now two names for the same thing, but not sure I'm a fan of outputpath. We already have output000 directories, and the laboratory contains more than just outputs.

labprefix is possibly the most accurate, but isn't intuitive.

aekiss commented 3 years ago

I'm happy to keep shortpath, with no synonyms. I haven't heard of anyone being confused by it, whereas 2 names for the same thing is bound to cause confusion.

navidcy commented 3 years ago

Let’s keep it. It’s OK :) Sorry for creating noise. We have much more pressing things we can deal with, eg, climate change?