payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
19 stars 26 forks source link

Docs don't have correct instructions for setting environment variables #308

Closed aidanheerdegen closed 8 months ago

aidanheerdegen commented 3 years ago

Docs list ompi option for setting environment variables

https://github.com/payu-org/payu/blame/master/docs/source/config.rst#L403-L410

as far as I can tell that option was renamed mpi here

https://github.com/payu-org/payu/commit/8aef1c9683d0cdf8a1deaab8e903402d70eab62a

marshallward commented 3 years ago

I guess ompi was a legacy flag. I have no memory of it. It may have been a dirty way to set OMPI_* environment variables to control MPI jobs.

I suspect you could just use env now in config.yaml:

env:
    UCX_LOG_LEVEL: 'error'
aidanheerdegen commented 3 years ago

Yeah that works, just need to update the docs to reflect it.

Guess how I found this out.

aidanheerdegen commented 3 years ago

(I can see from your suggestion that you already know)

aidanheerdegen commented 1 year ago

Related issue #347