Porting to pawsey - Githubissues

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems

Apache License 2.0

18 stars 25 forks source link

Porting to pawsey #326

Open aidanheerdegen opened 2 years ago

aidanheerdegen commented 2 years ago

Wrap ldd in try/except as executables on pawsey seem to be statically linked. Also for the same reason don't assume LD_LIBRARY_PATH is set.

Commented out call to load_modules. Pawsey has a lot of default modules that it relies on, so can't reliably monkey with that.

Removed a couple of the bespoke flags Marshall added to the slurm scheduler, and also explicitly pass through the PAYU environment variables. Also set in the current environment, but that didn't seem to make it through to the submitted job.

Closes #323

pep8speaks commented 2 years ago

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/envmod.py:

Line 106:5: E722 do not use bare 'except'

In the file payu/experiment.py:

Line 785:80: E501 line too long (83 > 79 characters)

In the file payu/schedulers/slurm.py:

Line 50:80: E501 line too long (83 > 79 characters)

Comment last updated at 2022-05-26 04:57:08 UTC

aidanheerdegen commented 2 years ago

This is a place-holder to make it easier to find and focus attention on what is required to port to magnus @ pawsey. Some of the changes are only to get it working, and aren't intended to be merged into master.

coveralls commented 2 years ago

Coverage decreased (-0.04%) to 42.205% when pulling 68a8a1f4b164d2a955ecea56b9008c10e1fde125 on pawsey into 0109f2f4137fb34321504dd30950e86dd4876aee on master.