search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Default to add '-wdir' arguments #351

Closed jo-basevi closed 11 months ago

jo-basevi commented 11 months ago

Change logic in experiments to default to adding -wdir to the arguments given to mpirun. Should close #341 and close #350

coveralls commented 11 months ago

Coverage Status

coverage: 41.798% (+0.5%) from 41.267% when pulling f04403998c833e8870c8d768781aa6a962e9ffc0 on jo-basevi:341-missing-wdir-arg into aacfd92570d6f33487ec4de47f9ad8b7a7fa8f12 on payu-org:master.

jo-basevi commented 11 months ago

Is the MVIPICH wrapper still used? If so, I could revert the changes and only add ‘-wdir’ arguments if mpi_module does not start with ‘mvapich’ rather than previously which was checking mpi_module starts with openmpi?

aidanheerdegen commented 11 months ago

Looks like MPICH supports -wdir in any case, so this code is redundant and should be removed

https://www.mpich.org/static/docs/v3.4.x/www1/mpiexec.html

See https://github.com/payu-org/payu/issues/350