search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Redundant code in init_models #355

Closed aidanheerdegen closed 10 months ago

aidanheerdegen commented 11 months ago

These two blocks of code do effectively the same thing:

https://github.com/payu-org/payu/blob/master/payu/experiment.py#L127-L128

https://github.com/payu-org/payu/blob/master/payu/experiment.py#L145-L147

Which makes the second block redundant if this line

https://github.com/payu-org/payu/blob/master/payu/experiment.py#L151

is changed to

        submodel_config['name'] = self.model_name
aidanheerdegen commented 10 months ago

Closed by #356