search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Add pypi build and publish to CD #362

Closed aidanheerdegen closed 9 months ago

aidanheerdegen commented 9 months ago

Add automated PyPI publishing to CD Workflow.

Closes #361

coveralls commented 9 months ago

Coverage Status

coverage: 42.016%. remained the same when pulling 8b4491755b2c0cb8cb271bf899e5541d3bd2aa0c on aidanheerdegen/issue361 into 6a1d1de128a7617f15dfca3d068e91a8e0127942 on master.

aidanheerdegen commented 9 months ago

Seeing as I managed to accidentally publish 1.0.19 to PyPI I guess that bit actually works. 😆

https://pypi.org/project/payu/1.0.19/

I'll leave that published version up, as we currently have no candidate for a tagged release.

aidanheerdegen commented 9 months ago

Thanks for the review. Lots of good feedback.

Also, is there any value in having the conda build use the PyPI dist

Probably there is yes, though this is mostly about not having a completely out of date version on PyPI, but that is not intended to be the official distribution channel.

Having said which, I always found it confusing that conda and pip install seemed to use slightly different, but overlapping, configuration/meta-data. If they can be made to be completely compatible then yeah, probably a good idea.

Not sure I am the person to do that, so someone else** could either make those changes in this PR, or make a subsequent PR to align them.

** @dougiesquire

dougiesquire commented 9 months ago

could either make those changes in this PR, or make a subsequent PR to align them

Let's merge this since it does the job (hopefully), and maybe leave that for another PR?