Closed jo-basevi closed 9 months ago
Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
I would have asked @angus-g for a review, but he wasn't a team member. Have added him, so he should be able to review this.
I've pinged you for a review @angus-g
In this branch, I've tagged on some code that runs at the end of
Mom6.setup()
that checks if files listed inparameter_file
ofMOM_input_nml
andSIS_input_nml
namelists in input.nml, are included in mom6's hard codedconfig_files
oroptional_config_files
.If the file is not present, I've added a warning, added the file to
config_files
and then copied the file to the workpath. Or is just a warning/error printed out during setup sufficient? If not, should the files be treated asconfig_files
oroptional_config_files
- i.e. raises an exception if file not found or not?From what I can tell, the only usages of
optional_config_files
andconfig_files
are:Should close #325