payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Add a check for MOM6 parameter filenames defined in input.nml #364

Closed jo-basevi closed 9 months ago

jo-basevi commented 9 months ago

In this branch, I've tagged on some code that runs at the end of Mom6.setup() that checks if files listed in parameter_file of MOM_input_nml and SIS_input_nml namelists in input.nml, are included in mom6's hard coded config_files or optional_config_files.

If the file is not present, I've added a warning, added the file to config_files and then copied the file to the workpath. Or is just a warning/error printed out during setup sufficient? If not, should the files be treated as config_files or optional_config_files - i.e. raises an exception if file not found or not?

From what I can tell, the only usages of optional_config_files and config_files are:

Should close #325

pep8speaks commented 9 months ago

Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-10-04 01:19:44 UTC
coveralls commented 9 months ago

Coverage Status

coverage: 42.772% (+0.7%) from 42.053% when pulling ab80d2008a9e6840ee98a869d859759bf1123cb3 on jo-basevi:325-read-mom6-parameter-filenames into fc83ec9827a3eab6defa40eaf5f674ca0581d75d on payu-org:master.

aidanheerdegen commented 9 months ago

I would have asked @angus-g for a review, but he wasn't a team member. Have added him, so he should be able to review this.

aidanheerdegen commented 9 months ago

I've pinged you for a review @angus-g