search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
21 stars 27 forks source link

Symlink instead of copy the `mod_def.ww3` input in the cesm_cmeps driver #368

Closed dougiesquire closed 1 year ago

dougiesquire commented 1 year ago

The WW3 model definition file input needs to be in the work directory and called mod_def.ww3. Previously this driver looked for a file in the inputs with "mod_def.ww3" in the filename and then copied that file to the work directory. This is bad practice. Now, the name of the file is assumed to be "mod_def.ww3" and this file is symlinked instead. Those setting up the configuration will need to ensure that a file with the right name is included in the inputs (e.g. using a symlink if the original input has a different name).

Closes #365

pep8speaks commented 1 year ago

Hello @dougiesquire! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-09-29 00:30:14 UTC
coveralls commented 1 year ago

Coverage Status

coverage: 42.016%. remained the same when pulling 7878fba2239d4616186d263324a67f29e0790dcf on dougiesquire:365_cesm_cmeps_ww3_input into 2d16f18ea24d764b07a41cbcb934cecb7646eaa9 on payu-org:master.

aidanheerdegen commented 1 year ago

Merge away.