search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
21 stars 27 forks source link

Read mom6 parameter files in cesm cmeps driver #373

Closed jo-basevi closed 1 year ago

jo-basevi commented 1 year ago

Refactored the code added in #364, so it can also be re-used for the mom component in cesm-cmeps driver.

I didn't add in mixin class in the end, as it just needed only one function (mom6_add_parameter_files) which I broke out of mom6 driver class. Though please let me know if using a mixin class would still be better!

Should close #371

coveralls commented 1 year ago

Coverage Status

coverage: 45.539% (-0.03%) from 45.573% when pulling 4498542a3dede7f655bd2f70a54414873b7a05e9 on jo-basevi:371-cesm-cmeps-read-mom6-parameter-files into 6cda0d51a28d1f90ec981804e129068181135d84 on payu-org:master.

aidanheerdegen commented 1 year ago

Neat! I've pinged @dougiesquire and @angus-g for a review.

Angus, don't worry if you have no opinion, just wanted to keep you in the loop as this reuses the code @jo-basevi just added to the mom6 driver.