search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Fix date-based restart pruning breaking on empty restart dirs #376

Closed jo-basevi closed 7 months ago

jo-basevi commented 8 months ago

Fix issue described in #375, Closes #375

Instead of raising an exception when restart file can't be found, a warning is printed and the restart is ignored from date-based restart pruning.

Also, moved code for restart file parsing for ocean_solo.res to a mixin mom class. This mixin class is then pulled into the mom and mom6 model drivers.

coveralls commented 8 months ago

Coverage Status

coverage: 45.707% (+0.2%) from 45.539% when pulling ea9cbef8731c81358b67c5f72503c3f8fe3f8997 on jo-basevi:375-date-based-restart-MOM-mixin into a336968a44fc4eddd847a5c7750a40bd00e0d9b0 on payu-org:master.

pep8speaks commented 8 months ago

Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-11-01 05:36:34 UTC