Fix for Issue #388 which broke executable reproducibility

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems

Apache License 2.0

18 stars 25 forks source link

Fix for Issue #388 which broke executable reproducibility #389

Closed aidanheerdegen closed 7 months ago

aidanheerdegen commented 7 months ago

Closes #388 which caused executable reproducibility to break in some situations.

Bug was due to a break rather than continue in Manifest.setup(). Links for other mainfests weren't created if scaninputs=True.

Modified existing test to trigger error. Test now passes.

pep8speaks commented 7 months ago

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-11-29 08:57:50 UTC

coveralls commented 7 months ago

coverage: 47.733%. remained the same when pulling 827181aa129d848e78c2f31393b0e2b2bb1c3a97 on aidanheerdegen/issue388 into 9523ae3e73ab65b681e27a38c2a77e95d4f8e843 on master.

aidanheerdegen commented 7 months ago

Hey @jo-basevi. I know you're super busy, but this is one of the fixes I'd like to get in before we merge the UUID/clone/branch stuff so would appreciate a review.

It shouldn't be a big deal, as it is a pretty simple fix for a fairly obvious error (mine as it turns out).