search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
18 stars 25 forks source link

Unnecessary files in UM config_files list. #419

Open MartinDix opened 4 months ago

MartinDix commented 4 months ago

The config_files list includes a number of files that the model doesn't actually use. Model configurations would be clearer without the duplicated namelists. See https://github.com/coecms/access-esm/issues/14

aidanheerdegen commented 4 months ago

A simple change would be to move them to the optional_config_files

https://github.com/payu-org/payu/blob/master/payu/models/um.py#L48

blimlim commented 4 days ago

I've had a go at removing the extra files listed here in a branch of payu (also thanks to @jo-basevi for helping get this working). In addition to shortening the um.py config list, I had to remove the following lines:

https://github.com/payu-org/payu/blob/8a4a1e2e9171f01e37bd34bfd8bb6f209f550873/payu/models/um.py#L144-L150

As far as I can tell, parexe is empty (at least in the pre-industrial configuration), and it appears to remain so after these lines are run. I just wanted to get confirmation that this would be safe to do, as I'm unsure of the original purpose of parexe.

Removing the extra config files and running for a few months produces identical simulations to unmodified configurations. The following shows the difference in surface temperature for a simulation with the configuration files removed and one without, on March 31:

download-5

If this sounds ok I'll add pull requests to add the changes to payu and the configurations.