search

payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
21 stars 27 forks source link

Updated metadata schema URL #429

Open aidanheerdegen opened 8 months ago

aidanheerdegen commented 8 months ago

The location of the metadata schema is changing

https://github.com/ACCESS-NRI/schema/pull/12

This will require an update to the URL in metadata.py

https://github.com/payu-org/payu/blob/421431b52c24dd57fa0ad023d46b739667133af7/payu/metadata.py#L39

We will need flag that this is being deprecated and when that file is removed it will break existing deployed versions of payu.

Note for the future, if we had used a specific commit then there would be no problem with deleting/moving the file in the schema repo, i.e.

https://raw.githubusercontent.com/ACCESS-NRI/schema/36abe2fe28eb2853a54f41c5eedfd964617d9d68/experiment_asset.json

rather than

https://raw.githubusercontent.com/ACCESS-NRI/schema/main/experiment_asset.json

aidanheerdegen commented 7 months ago

Metadata URL was updated in #434 but we should keep this open until we deprecate deployed versions of payu with old URL location.

AFAICT this only affects a single deployed version:

/g/data/vk83/apps/payu/1.1

When we deploy the next version we should add a deprecation notice to the 1.1 version module file and once we have a couple of versions deployed over the top it should be fine to remove that version and the deprecated schema file and close this issue.