payu-org / payu

A workflow management tool for numerical models on the NCI computing systems
Apache License 2.0
21 stars 27 forks source link

Mainfest `reproduce` options don't seem to do what they say on the box #456

Closed dougiesquire closed 3 months ago

dougiesquire commented 4 months ago

The Payu docs say that with the manifest:reproduce:exe flag set in the config.yaml Payu "will refuse to run if hashes do not match". This does not seem to happen. Instead Payu silently runs using the exectuables specified in the manifest.

Probsibly the same is true for manifest:reproduce:input and manifest:reproduce:restart - I haven't tested.

To reproduce

Clone one of the access-om2-configs release branches (which all have manifest:reproduce:exe = True), modify an exectuable path in config.yaml, and run payu setup or payu run. Payu will behave as if no modifications were made to the config.yaml.

aidanheerdegen commented 4 months ago

I agree this is bad. I think it's my fault, and weirdly it was a conscious decision, but it does not match the documentation.

I was sure there was an existing issue for it, but I looked and couldn't find anything, so thanks for making one.