pazaan / 600SeriesAndroidUploader

Your Medtronic 600-series pump data, direct to Nightscout
http://pazaan.github.io/600SeriesAndroidUploader/
MIT License
189 stars 311 forks source link

token-based access: works, but nags that it wouldn't #188

Closed th122 closed 6 years ago

th122 commented 6 years ago

Default disclaimer: I'm in love with indra, you guys are awesome!

Your Environment

Brief Explanation of Issue

indra warns to set AUTH_DEFAULT_ROLES even if there's a token-based acces with matching permissions of devicestatus-upload and readable. This seems to be cosmetic only, since data gets uploaded successfully

Uploader Error Code

Steps to Reproduce (for bugs)

  1. set up an access token with permissions devicestatus-upload, readable
  2. set the upload link to contain the access token (ignoring the API secret) https://<host>.ns.10be.de:<port>/?token=indra-0...
  3. Watch log giving instructions on how to set authDefaultRoles on azure/Heroku :)

Severity Score

1 - This seems to be cosmetic only, since data does get uploaded and backfilled successfully. (sgv and basal changes and pump profile, so it's not xDrip or AndroidAPS sneaking in what they got by xDrip broadcast)

Pogman commented 6 years ago

Yep this used to be an issue that would block any uploading but got changed in NS to use a default of 'readable' and now AUTH_DEFAULT_ROLES acts only as a user override.

*** this check removed in v6.1

Pogman commented 6 years ago

closing fixed and released in v0.6.1