reply: use `email.utils.formataddr` as in compose command

pazz / alot

Terminal-based Mail User Agent

GNU General Public License v3.0

695 stars 164 forks source link

reply: use `email.utils.formataddr` as in compose command #1483

Closed stregouet closed 4 years ago

stregouet commented 4 years ago

to format address used in From header we should use formataddr from stdlib, this will handle encoding properly (we shouldn't leak non-ascii characters in headers). Actually this is same behaviour in compose command

(closes #1482)

patricktotzke commented 4 years ago

No: the stdlibs formataddr is broken, or at least has a strange semantics that introduced problems in alot. We're deliberately not using that any more.

stregouet commented 4 years ago

yes pazz told me on issue #1482 about problem with stdlib formataddr so why using it with compose command?

pazz commented 4 years ago

I believe this can be closed? If we use the stdlib routing explicitly somewhere then this is by accident and should be fixed independently I think.

stregouet commented 4 years ago

yes you're right. I close it