search

pazz / alot

Terminal-based Mail User Agent
GNU General Public License v3.0
700 stars 163 forks source link

overhaul widgets.ANSIText #1503

Closed pazz closed 4 years ago

pazz commented 4 years ago

This re-implements the ANSI escape sequence parsing in alot.widgets.ANSIText and is intended to avoid ugly try/catch constructions

see issue #1502

pacien commented 4 years ago

This seems to fix the error encountered in #1493.

However the sample email provided as an example in that issue is displayed without any colours or bold formatting in alot.

Screenshot of the same content displayed by alot on the left and by bat on the right:

15888813506460

pazz commented 4 years ago

Thanks for the input, @pacien. Try again with the updated patch. It was actually not a bug but a feature :) I simply did not yet include any 8-bit colours that were set "in one go", several attributes in one escape sequence. Your email now looks as expected for me. Thanks also for the colordiff tip, that's awesome!

pacien commented 4 years ago

I confirm that the new patch now allows colours to be displayed, however the bold formatting doesn't seem to be applied on the two coloured lines in the example above.

pazz commented 4 years ago

I confirm that the new patch now allows colours to be displayed, however the bold formatting doesn't seem to be applied on the two coloured lines in the example above.

Thanks. Try once more :)