pazz / alot

Terminal-based Mail User Agent
GNU General Public License v3.0
696 stars 164 forks source link

Display all printable multipart/mixed mime parts #1521

Open meskio opened 4 years ago

meskio commented 4 years ago

Describe the bug Is not uncommon that an email contains multiple printable mimeparts in a multipart/mixed. Currently only the first printable part gets displayed and the others are ignored. You need to use togglemimetree or something similar to see that there is something more there. Alot used to display all the parts, but somehow recently it has stopped doing so.

Some common cases I know of multiple multipart/mixed printable parts:

In the case of mailman not seeing the footer is not so bad. But in schleuder mailing lists we only see the original headers and not the body of the email.

Software Versions

To Reproduce Steps to reproduce the behaviour:

  1. open a thread from a mailman/schleuder mailing list
  2. see that the displayed content is not all that you can see with togglemimeparts
meskio commented 4 years ago

I see the change was introduced by #1421, by f99ba2b4d20c02f487626c69f4c9686f90a247fc. Before (in extract_body) there was some walk around the parts collecting a list of parts to display, after that change only one part will be selected and displayed.

@pazz is this change intentional? Should I give it a try to bring the functionality back so alot displays all multipart/mixed parts?

pazz commented 4 years ago

This was not a change I intended but also nothing I can't live with. Basically I'm very happy to delegate the extraction of a message "body text" to the email library instead of hacking or own methods. That said, you're welcome to see if the email lib based thing can be tweaked to do what you want and make it configurable.