search

pazz / alot

Terminal-based Mail User Agent
GNU General Public License v3.0
696 stars 164 forks source link

valign message to top of screen #1528

Closed mrichar1 closed 4 years ago

mrichar1 commented 4 years ago

I think this is all that is needed to fix #1491. Tests seem to pass fine, but there's a chance it introduces unexpected behaviour. Not sure to what extent the test suite can accommodate checking things like screen positioning etc?

I'll see about running this branch for a bit (with urwidtrees from master) and see if I can create any bugs, especially with things like folding etc.

pazz commented 4 years ago

FYI: I've just made a release over at urwidtrees (with my other github handle but can't be bothered to rewrite the commits). So If you'd amend the dependencies to urwidtrees >= 1.0.3 here, we can push this PR.

pazz commented 4 years ago

The travis fail is expected for now, as urwidtrees is not updated on pip.

mrichar1 commented 4 years ago

Just saw the comment about this not working - weirdly it isn't working for me either - though I did have it working before making the commit... let me have a dig and see what I missed or did wrong between testing and committing! :thinking:

mrichar1 commented 4 years ago

OK - so it looks like this is my fault for not testing the behaviour fully with all the different actions!

It seems that if you open a thread (with all messages unfolded),then select (default enter key) does the right thing and collapses the message and focuses the next one to the top. However if you use move next (default space key) then this doesn't happen. (I'm running from the git repo, without a local config file, but If you can double check and confirm this is the current behaviour for you too that'd be useful!)

I'll have a dig and see if I can figure out what happens in a move that is different in the code (and also consider if there are any other actions which need updated too).