I spent entirely too long today fixing my own instance of #1560, because I'm not running alot in X11 and #460 and 2a7d1fd2dcc7354b06faa0da5574324b3578eba1 make alot simply fall back to non-spawning behaviour silently.
Initially I special-cased tmux outside of X11 in alot/commands/globals.py, but then I found out that I'm supposed to write a hook. So I did that, but I'd like to document it publicly.
There's also a bug where the thread result of that hook is not respected because self.in_thread gets set directly.
Ensure the thread result of the touch_external_command hook is not overridden.
pazz
commented
1 year ago
I spent entirely too long today fixing my own instance of #1560, because I'm not running alot in X11 and #460 and 2a7d1fd2dcc7354b06faa0da5574324b3578eba1 make alot simply fall back to non-spawning behaviour silently.
Initially I special-cased tmux outside of X11 in alot/commands/globals.py, but then I found out that I'm supposed to write a hook. So I did that, but I'd like to document it publicly.
There's also a bug where the
threadresult of that hook is not respected becauseself.in_threadgets set directly.threadresult of thetouch_external_commandhook is not overridden.touch_external_commandhook and corresponding shell script for tmux outside of X11. (Thanks to @cjpbirkbeck in https://github.com/pazz/alot/issues/1560#issuecomment-907222165)