Closed lucc closed 2 months ago
Is this work in progress or ready to merge? I trust you know what you are doing wrt github actions as I don't :)
Sorry this is still WIP as some tests are still failing in the nix sandbox.
cool, no worries :)
@pazz & @guludo what do you think about 1359aba? I just removed the broken test, it would also be possible to add some validation code to the read_notmuch_config function to throw that exception again. We are only using the following values from the notmuch config:
maildir.synchronize_flags
, bool as the string "true" or "false" in the notmuch configdatabase.path
, a path as a string in the notmuch configsearch.exclude_tags
, a list of strings as a ";"-separated string in the notmuch configso we could also parse these into special values inside read_notmuch_config
.
@pazz & @guludo what do you think about 1359aba?
Looks good to me.
I just removed the broken test, it would also be possible to add some validation code to the read_notmuch_config function to throw that exception again.
That would make sense. Ideally, notmuch config
would raise an error, since the documentation says that valid values are either true or false, but that does not seem to be the case.
From my side this is ready for review (and merge).
@pazz is it ok to ignore the codeclimate check?
This adds CI jobs to run the nix build of alot and also a second nix target with a ci job to build the sphinx docs.
Some test are fixed or removed, see commit messages. The last question about the fixed test is https://github.com/pazz/alot/pull/1653#issuecomment-2094563736
The plan behind this is that we have some CI that is green until the pip/poetry installation of alot is fixed again and our other CI jobs can be trusted. And also to check that the nix code works correctly because I personally rely on it.