pazz / alot

Terminal-based Mail User Agent

GNU General Public License v3.0

695 stars 164 forks source link

alot/version.py increases alot/VERSION #266

Closed ghost closed 12 years ago

ghost commented 12 years ago

If there is something done in the repository alot/VERSION will be changed you will get unstaged changes in git, even when you just pull from github your alot/VERSION will differ from upstream. Please do not use this script or follow this advice in alot/version.py:

This will automatically update the VERSION file, if

necessary. Note that the VERSION file should not be

checked into git; please add it to your top-level .gitignore file.

pazz commented 12 years ago

i recently checked in VERSION on purpose. the reason is that without this file a build or install depends on the presence of git and git metafiles in .git. This fails for tarballs and introduces unnecessary problems for packagers on minimal build hosts.

note that an entry in .gitignore does not prevent your changed file from being checked in. use git update-index --assume-unchanged alot/VERSION to prevent changes from being committed.

don't hesitate to tell me if you find a better solution. this should go into the FAQ and developer manual.

ghost commented 12 years ago

Please update the FAQ and developer manual then. Thanks for the command.

pazz commented 12 years ago

done : http://pazz.github.com/alot/

teythoon commented 12 years ago

I told you that this was a bad idea...

pazz commented 12 years ago

the autogeneration foo? or checking the file in?

teythoon commented 12 years ago

Writing self modifying code in 2011 ;)

pazz commented 12 years ago

Quoting Justus Winter (2012-01-15 13:45:23)

Writing self modifying code in 2011 ;) aye. sure wasn't the greatest idea after all. I wouldn't mind switching back to static strings in alot.init in the end. I kinda liked the idea that alot --version gives you the correct version string and doesn't point to the last release tag in development versions.