search

pazz / urwidtrees

tree widgets for urwid
GNU General Public License v3.0
52 stars 18 forks source link

setup.py: mock should not be in both install_requires and extras_require #48

Closed teapot9 closed 4 years ago

teapot9 commented 4 years ago

It looks like mock is only used for the docs, so I would suggest removing it from install_requires.

Also, since it is included as unittest.mock in Python 3.3+, I would suggest using 'mock;python_version<"3.3"' to only pull it when needed. Commit 76a79ae4288f720f4d3cd4a580d4eabcdd54c38b already provides support for it.

pazz commented 4 years ago

Thanks, that's be OK with me. Can you send a PR?

From: Louis Leseur notifications@github.com Sent: Tuesday, August 25, 2020 10:17:40 PM To: pazz/urwidtrees urwidtrees@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [pazz/urwidtrees] setup.py: mock should not be in both install_requires and extras_require (#48)

It looks like mock is only used for the docs, so I would suggest removing it from install_requires.

Also, since it is included as unittest.mock in Python 3.3+, I would suggest using 'mock;python_version<"3.3"' to only pull it when needed. Commit 76a79aehttps://github.com/pazz/urwidtrees/commit/76a79ae4288f720f4d3cd4a580d4eabcdd54c38b already provides support for it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/pazz/urwidtrees/issues/48, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEZNZ6VMCN3GY6K2NUSC6DSCQS7JANCNFSM4QLDEETQ.