search

pb33f / libopenapi

libopenapi is a fully featured, high performance OpenAPI 3.1, 3.0 and Swagger parser, library, validator and toolkit for golang applications.
https://pb33f.io/libopenapi/
Other
362 stars 46 forks source link

Pin digital ocean commit in tests #287

Closed maboehm closed 3 weeks ago

maboehm commented 3 weeks ago

I wanted to open a PR for something else, but the tests were failing.

The digital ocean API repo does not change often, but when it does it likely breaks the tests here. I'd suggest to pin a certain commit.

If you want, I can also de-duplicate the checkout code between the tests, but it looks like the tests were explicit on purpose

daveshanley commented 3 weeks ago

Thanks for pinning them, it was getting annoying updating the tests all the time.