Closed TristanSpeakEasy closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.65%. Comparing base (
c3eb16d
) to head (ae88d35
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
a draft until the underlying dependency is merged otherwise we either need to use speakeasy's fork without a replace statement or everyone needing to use this version has to add their own replace statement
I will need to look at this in depth, thank you for this work!
I will need to look at this in depth, thank you for this work!
@daveshanley we have integrated this branch into the speakeasy products and its working as expected and much nicer devex
no longer using a replace directive so good to go
I started testing the specific PR, and it looks like it is working as expected! Thanks a lot, @TristanSpeakEasy
This PR adds support for the iterators being added to the ordered map library, this cleans up the DevEx when working with ordered maps in the high level models but has also cleaned up a bunch of the implementation code as well
I have linked to my fork of the iterators change for now, but I can hold of this PR (just let me know) until its merged into the library
https://github.com/wk8/go-ordered-map/pull/41
Just some notes about things I noticed while doing this refactor: