search

pb33f / libopenapi

libopenapi is a fully featured, high performance OpenAPI 3.1, 3.0 and Swagger parser, library, validator and toolkit for golang applications.
https://pb33f.io/libopenapi/
Other
487 stars 64 forks source link

maint: relax go version, go mod tidy #331

Closed dstrelau closed 2 months ago

dstrelau commented 2 months ago

Hi there! With the recent bump to go 1.23.0 here, we were seeing this force a change in our project to also use go 1.23.0 explicitly.

My understanding is that the go directive is used to specify the language semantics in use in the project, while the toolchain directive can be used to specify an exact toolchain version requirement. We'd like to be able to have go 1.23 (no patch) for semantics but something like toolchain go1.23.1.

I ran go mod tidy after changing L3, which dropped a few seemingly unused dependencies.

TristanSpeakEasy commented 2 months ago

@daveshanley can we get this one merged please

daveshanley commented 2 months ago

@daveshanley can we get this one merged please

I'm currently out of the country organizing my mother's funeral, I'll be back online in a week.

TristanSpeakEasy commented 2 months ago

@daveshanley can we get this one merged please

I'm currently out of the country organizing my mother's funeral, I'll be back online in a week.

Sorry to hear that, hope it all goes okay

dstrelau commented 2 months ago

After investigating this further, I believe the current form of go 1.23.0 is actually correct. One of the many comments here indicates that the .0 form is pretty much always what you want.

Additionally, the Go toolchain documentation gives preference to doing the Go update via go get go@1.X which also adds the patch version.