search

pb866 / kimbal

Tool for basic statistics of time logs by Kimai.
GNU General Public License v3.0
0 stars 0 forks source link

Make sure attribut __vacdays is only set during init #8

Closed pb866 closed 2 years ago

pb866 commented 2 years ago

When public method vacation_days is called, the attribute vacationdays should not change as this leads to wrong results in the output of the stats method.

pb866 commented 2 years ago

Quick fix for v0.1: hide method vacation_days. For v0.2 make sure, vacation_days das not change any Kimai attributes. Make a public function vacation_days as described in #7 that does not change attributes and a private method that makes use of the public function that is allowed to change attributes.

pb866 commented 2 years ago

Closed by 2fe7b57ebc72dc8b04962ee23eb1c4d4f2e9a956.