search

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
367 stars 125 forks source link

Ugly white lines and bad thread height when in wide mode in 3.12.1 #128

Closed dusatvoj closed 3 years ago

dusatvoj commented 3 years ago

Describe the bug Hi, I've recently upgraded to RC v3.12.1 and RC-dark-mode to the code from master branch and I have some ugly white lines and bad height of wide thread window there

To Reproduce Steps to reproduce the behavior:

  1. Install RC 3.12.1
  2. Apply dark mode

  3. image image

Expected behavior Pre 3.12 look (except some ugly white lines too) image

Screenshots Above

Desktop (please complete the following information):

Additional context Any

pbaity commented 3 years ago

I'll work on the white lines, but I don't think the dark mode is causing the change in the height of the thread window.

pbaity commented 3 years ago

@dusatvoj Added a fix for this in #136, check it out and let me know what you think.

dusatvoj commented 3 years ago

@pbaity Looks much better. There's last white line in the middle and It will be excelently fixed. :hearts: image

pbaity commented 3 years ago

Interesting, I don't see that white line on the side of the thread panel - in the picture I posted in that PR of the thread panel it's not there, and I still don't see it.

dusatvoj commented 3 years ago

Interesting. Nevermind :grinning: Thank you for PR.