No switch button after apply css and js

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat

MIT License

367 stars 125 forks source link

No switch button after apply css and js #133

Closed itJunky closed 3 years ago

itJunky commented 3 years ago

First i set it in version 3.12.0. Because i don't see any special version of dark-mode for it. Afer that i clean browser data(not cookies). No switch button for dark-mode at top of left menu. Next, i'll update rocket to 3.13.0 version and check custom CSS and custom script fields. Not empty and correct text, but no switch again :( After that i'll change deafault in js to const darkModeDefault = true; And nothing changes in interface too :(

No errors in F12 console. How can i debug and fix it?

fdellwing commented 3 years ago

Did you make sure you pasted the script into Custom Script for Logged in Users? It's the third field from top.

itJunky commented 3 years ago

Yes, beacuse i see only one "Custom scripts" field.

fdellwing commented 3 years ago

Click on custom scripts and there will be 3 text fields.

Blueshawk commented 3 years ago

@itJunky FWIW It may take a bit of scrolling to shake them out, at least on the Linux desktop app. When I scroll the others show up. The first one is for logout. @fdellwing Don't we need to put those button png's somewhere on the server?

pbaity commented 3 years ago

@Blueshawk the buttons are actually SVGs, not PNGs, so no need to have them on your server.

Blueshawk commented 3 years ago

Got it sorted now thanks. I actually did something silly and didn't catch it till just now, so sharing. I usually clone stuff from git so when I decided to just grab the two files instead I didn't realize I got the html page.. (facepalm) Kudos to rocketchat for not exploding when fed huge amounts of garbage. LOL

@itJunky Check to be sure your script is actually what you think it is.

This is nifty btw, thanks!

itJunky commented 3 years ago

Click on custom scripts and there will be 3 text fields.

Wow, thanks. I set code to first field, but need set it to third field. It's because i see translated to russian language field names. Before i think it just different after translation.

Now it's worked.