pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
369 stars 126 forks source link

Variants not visible in Poll application and something not visible in prune menu #141

Closed ankar84 closed 3 years ago

ankar84 commented 3 years ago

Describe the bug When you install Rocket.Chat Poll application and create some poll - you can't see variants in dark mode

To Reproduce Steps to reproduce the behavior:

  1. Install Poll App
  2. Create poll
  3. Chech variants

Expected behavior All variants should be visible

Screenshots Pool issue image image

Prune menu image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

ankar84 commented 3 years ago

I guess in my case that code will fix Poll App issue

/***** Poll App *****/
body.dark-mode [data-username="app.poll"] .rcx-css-erwtrf {
    color: var(--color-white) !important; 
}

Important that in my case data-username="app.poll" but in dark-mode.css is data-username="poll.bot" for some reason

pbaity commented 3 years ago

Interesting, @ankar84 what version of Rocket.Chat are you using? data-username="poll.bot" works for me but not data-username="app.poll" on RC 3.13.2.

data-username="poll.bot"

image

data-username="app.poll"

image

ankar84 commented 3 years ago

Interesting, @ankar84 what version of Rocket.Chat are you using?

3.14

data-username="poll.bot" works for me but not data-username="app.poll" on RC 3.13.2.

data-username="poll.bot"

image

data-username="app.poll"

image

For some reason that poll robot is named differently in your and mine environments

pbaity commented 3 years ago

Got it. Based on that see my suggestion here: https://github.com/pbaity/rocketchat-dark-mode/pull/142/files#r636205362

ankar84 commented 3 years ago

Poll issue fixed by https://github.com/pbaity/rocketchat-dark-mode/pull/142