Rocket.Chat 4.3.0 - Githubissues

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat

MIT License

369 stars 126 forks source link

Closed ae5960e8-a6fc-491f-b252-898ecf59af95 closed 2 years ago

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 2 years ago

Rocket.Chat 4.3.0 is out, some elements of the script need to be updated to accommodate the new changes.

TBG-FR commented 2 years ago

I started working on 4.3.0 modifications to update the dark mode, here are some elements :

Message options menu -> fixed
Account menu -> unable to see the issue, can you provide a screenshot ?
Message info OK button -> unable to see the issue, can you provide a screenshot ?
Video Conference "Cancel" button -> RC issue, this button is missing rcx-button--ghost class (should we open a PR ?)
2FA -> not tested yet
I found some other elements, I'll update this asap

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 2 years ago

Account menu:

Message info OK button:

pbaity commented 2 years ago

These issues were fixed in #162 . If you find any other specific problems, feel free to open new issues for those.

TBG-FR commented 2 years ago

@ae5960e8-a6fc-491f-b252-898ecf59af95 Can you check if "Message info OK button" is fixed ? If not, where should I go to display that popup/modal ?