pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
366 stars 125 forks source link

Account name in status menu unreadable #165

Closed ae5960e8-a6fc-491f-b252-898ecf59af95 closed 2 years ago

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 2 years ago

Previously, I had suggested changing the background of this element from white to dark, to match the dark theme, however this has resulted in the user's account name in the status menu becoming unreadable. sss

Secondly, I'm now of the opinion that white was more readable and appropriate than the new colour. I think this change should be reverted, or, instead, it could use a dark colour which does not match the background on which is hovers above to improve readability.

TBG-FR commented 2 years ago

My bad, I didn't see this one ! I'll fix it asap 😉

To answer your second point, I also tried a dark "lighter" color, thinking it was better, but I changed my mind because in normal/light mode, Rocket Chat uses one color for the sidebar, and one color for the main chat panel and menus... So I tried to do the same, including border shadow color modifications to improve readability

I'll show you some screenshots so everyone can decide which one is better (maybe by upvoting each message ?)

TBG-FR commented 2 years ago

Here's RocketChat original colors

RC_Menu_Original

And here's what I did in #162

RC_Menu_Dark

TBG-FR commented 2 years ago

One option could be to use --color-dark-medium

RC_Menu_DarkMedium

TBG-FR commented 2 years ago

Another option would be to use --color-darkest

RC_Menu_Darkest