search

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
369 stars 126 forks source link

4.4.2 (small fixes) #171

Closed TBG-FR closed 2 years ago

TBG-FR commented 2 years ago

Hello there !

Two small fixes for 4.4.2

Didn't noticed any other issue related to new version, but don't hesitate to report them !

pbaity commented 2 years ago

Hey @TBG-FR , thanks again! For me this doesn't fix the light-colored hover in the channel members list:

image

Is that what you are referring to?

TBG-FR commented 2 years ago

You're right, I forgot to add body.dark-mode before the rule, that should be fixed now

pbaity commented 2 years ago

@TBG-FR When you have time, see my last comment and let me know what you think. I prefer using the variables rather than overwriting rules when possible. (Just a reminder since issues #172 and #173 came in, and this should fix those.)

TBG-FR commented 2 years ago

@TBG-FR When you have time, see my last comment and let me know what you think. I prefer using the variables rather than overwriting rules when possible. (Just a reminder since issues #172 and #173 came in, and this should fix those.)

I agree with you, I prefer using the variables too. However, your suggestion doesn't fix #172 (because it uses a custom rule 😞 ) I'll fix these two anyway, commits on the way 😉 Thank you for reviewing that !