Support for 4.7.0 - Githubissues

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat

MIT License

366 stars 125 forks source link

Support for 4.7.0 #178

Closed bkraul closed 2 years ago

bkraul commented 2 years ago

Is your feature request related to a problem? Please describe. With the release of 4.7.0 develop, an incompatibility with the theme/mode seems to exist. This is the current look of the applied dark theme:

Describe the solution you'd like Better support for 4.7.0

Describe alternatives you've considered Considered modifying the script to account for any new clases, but it has proved ineffective (without the full understanding of how it is addressed).

lpuv commented 2 years ago

This please!!

pbaity commented 2 years ago

Thanks for bringing this up, I'll get to it ASAP. I've been busy but I should be able to get it worked out by next weekend (5/6-7) at the absolute latest (and hopefully before that).

TBG-FR commented 2 years ago

Do you still experience this ? I couldn't reproduce it

bkraul commented 2 years ago

With later versions 4.7.x+ it seems it displays better, but there are still issues, especially with the Administration UI:

There are actually paragraphs of invisible text before each of those buttons.

TBG-FR commented 2 years ago

Perfect ! I'm working on fixing the new issues 🤙

I think @ankar84 is also working on the Admin UI (see #181 & #182)

TBG-FR commented 2 years ago

Connectivity Services page will be fixed in #185 😄

pbaity commented 2 years ago

@bkraul I just saw that I originally intended to fix this in early May - so sorry I didn't. That weekend ended up being an ER trip when one of my kids got sick 😅 Thanks to @TBG-FR for picking it up though.

Fixed by #185. If anybody sees the issue reoccur just reopen this issue!