pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
369 stars 126 forks source link

Dark Mode not working right in RC5.0 #189

Closed D34DC3N73R closed 1 year ago

D34DC3N73R commented 1 year ago

Describe the bug class names appear to have changed in RC 5.0

To Reproduce Steps to reproduce the behavior:

  1. Apply dark mode CSS in RC 5.0
  2. Observe

Expected behavior Dark mode works in RC 5.0

Screenshots image

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context Add any other context about the problem here.

ankar84 commented 1 year ago

@TBG-FR Hello! We need your help here!

lpla commented 1 year ago

MRW I opened Rocket Chat this morning:

eyes

TBG-FR commented 1 year ago

Will be working on that today or tomorrow 😉 Don't hesitate to check all (sub)menus and items to report them all !

avpnusr commented 1 year ago

Seems like nearly all things are normal - at least for my installation.

Only the messages in the chat-windows have a white background color and get (the right) grey color, while hovering over it.

Don't know if this helps, but in Dev-Tools I get this while selecting the element...

image

ankar84 commented 1 year ago

Don't hesitate to check all (sub)menus and items to report them all !

Discussion list in chat image Call modal image Admin UI - Info (Low contrast) image Admin UI - Users (Name not visible) image

Rest looks fine in general...

Will be working on that today or tomorrow

Thank you so much for your effort!!!

pbaity commented 1 year ago

Not all heroes wear capes. @TBG-FR is awesome!

TBG-FR commented 1 year ago

Eveything you reported @ankar84 should be fixed now, including Call modal

@here if you guys could try my modifications and report any missing things, that would be great ! 💪

Thanks for all the kind words 🙇

ankar84 commented 1 year ago

Eveything you reported @ankar84 should be fixed now, including Call modal

You are fantastic, man!!!!

@here if you guys could try my modifications and report any missing things, that would be great ! 💪

Already checking!

pbaity commented 1 year ago

This should be closed by #190 . Thanks so much to @TBG-FR 's amazing work there!

If anyone finds additional issues, please open a new issue with the details.