pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
366 stars 125 forks source link

Apps page on 5.1.0 is largely ignored by dark mode #193

Closed chotaire closed 2 years ago

chotaire commented 2 years ago

Describe the bug In Rocket.Chat Version 5.1.0, the Apps page has been reworked and is mostly ignored by rocketchat-dark-mode.

To Reproduce Steps to reproduce the behavior:

  1. Update to Version 5.1.0
  2. Go to Administration -> Apps

Expected behavior Dark mode be dark.

Screenshots

944a49bfffab41227fed6e07bb9d0131

chotaire commented 2 years ago

Feel free to go from here. I fixed the dropdowns and app info pages too.

c86cf64dd18baa1cffeceb67bb70d8d5

e68925a60c959f56a3fa21772d67b6a9

The Apps section is a mess that ended up extremely inconsistent for theming compared to other Rocket.Chat sections, so it will require a lot of tinkering (feel free to correct me if I didn't see the obvious). Here we go:

/* Fixed Apps page in 5.1.0 - https://github.com/pbaity/rocketchat-dark-mode/issues/193 */
body.dark-mode .rcx-css-2eycu6, 
body.dark-mode .rcx-css-15czep1, 
body.dark-mode .rcx-css-1njby22, 
body.dark-mode .rcx-css-1kf73wc, 
body.dark-mode .rcx-css-1aw2eor, 
body.dark-mode .rcx-css-1ftswnq {
    background-color: var(--color-dark) !important;
}
body.dark-mode .rcx-css-11j9j9r {
    background-color: var(--color-darker) !important;
}
body.dark-mode .rcx-css-1mu6dlv, 
body.dark-mode .rcx-css-1pjqz2k, 
body.dark-mode .rcx-css-358xm4 {
    background-color: var(--color-darkest) !important;
}
body.dark-mode .rcx-css-m9e8zc, 
body.dark-mode .rcx-css-1vtn02s, 
body.dark-mode .rcx-option__content, 
body.dark-mode .rcx-css-19z81xy {
    color: var(--primary-font-color) !important;
}
body.dark-mode .rcx-css-1h8icge {
    /* Note: Rocket.Chat is not CSS3 compliant here. */
    border-block-start: var(--color-darker) !important;
}

I decided to send a pull request. Let's collaborate: https://github.com/pbaity/rocketchat-dark-mode/pull/194

pbaity commented 2 years ago

Thanks for fixing this in #194 @chotaire ! Great work.