Closed ddkedr closed 1 year ago
@ddkedr Thanks for opening the issue! Glad to hear from you and I'm glad you enjoy the dark theme, though it's hardly my work - there are a lot of fantastic and talented contributors to this project that have made it great.
I appreciate those screenshots, but to help me out, could you also list out their locations (e.g., Administration > Settings) along with specifically mentioning which elements have light borders? Of course I see them in your screenshots, but I want to make sure I find them all and fix them. (If you've found more than what's above, include both descriptions and screenshots for those too!)
Once we have a detailed list of borders that need to darkened for this issue, we can fix them specifically and solve this issue. (If you find more after that, you can open another issue.)
@ddkedr Rocket.Chat 6.0.0 comes with its own official dark mode integrated and has this border issue fixed. So updating to Rocket.Chat 6.0 (and removing this rocketchat-dark-mode from your installation) would fix that issue for you.
If you are insisting to stay on a version lower than v6.0.0 (e.g. if you really need custom roles without an enterprise subscription), someone of us who hasn't updated yet might be willing to submit a patch?
Thank you, @pbaity for your effort, you're doing an amazing job. But I am in fact on enterprise version, so I'm going to update to version 6.0
@ddkedr That's what I'd recommend as well. Thanks for using our dark theme though!
Describe the bug Inputs and button borders are too light
To Reproduce It can be seen pretty much everywhere
Expected behavior It would be nice of those border will be darker or ever transparent (depending on the object)
Screenshots Here are a couple examples. Borders look off
Desktop (please complete the following information): Latest FireFox
Additional context Love your work. This is the best overall Dark theme for Rocket.Chat!