search

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
367 stars 125 forks source link

Fix color for unread badge in threads and status indicator on user cards #66

Closed stenrose closed 4 years ago

stenrose commented 4 years ago

In the current release the blue circle doesn't show in the right hand sidebar for threads. The user presence indicator circle on user cards showing if they are online, away, busy, offline etcetera doesn't show either (relates to #63).

This should fix both issues mentioned above, without (hopefully) causing any regressions.

pbaity commented 4 years ago

@stenrose Thank you so much for figuring out the user presence icon issue! Brilliant!

For the thread notification icon, can you share some screenshots of what you mean (with and without your fix, if possible)? I don't use threads very often and can't spot the difference with your changes, but it's probably just me.

One other request - please fix the whitespace/indentation in your PR. We use size 4 tabs. It's not too big a deal, but it saves me from going back to fix it afterwards. Thanks!

stenrose commented 4 years ago

Actually noticed several issues with the changes I did. So need to revert and remake it later.