Closed ulope closed 3 years ago
@ulope Using our existing dark color variables I tried this:
body.dark-mode .message .body > table thead tr {
background-color: var(--color-darkest);
}
body.dark-mode .message .body > table tr {
background-color: var(--color-dark);
}
body.dark-mode .message .body > table tr:nth-child(2n) {
background-color: var(--color-darker);
}
This is the result: What do you think? Too dark? I may need to use hex colors instead of our variables if so.
Hm the alternating row pattern is a bit difficult to see, otherwise it's fine I'd say.
Ah, I forgot I also have a --color-dark-medium
. Changed the rules to this:
body.dark-mode .message .body > table thead tr {
background-color: var(--color-darkest);
}
body.dark-mode .message .body > table tr {
background-color: var(--color-dark-medium);
}
body.dark-mode .message .body > table tr:nth-child(2n) {
background-color: var(--color-dark);
}
Which results in: If you like this better, I'll open a PR for it.
Describe the bug Inline tables (via markdown) are unreadable with light text on light background.
To Reproduce Steps to reproduce the behavior:
marked
(Admin -> Message -> Markdown)Marked Tables
Expected behavior The table to be readable
Additional context This additional CSS fixes the issue for me (probably would need some touching up to fit with the rest of dark mode):