search

pbaranay / django-magic-cards

A pluggable Django app for the Oracle text of all Magic: the Gathering cards
MIT License
7 stars 1 forks source link

Speed up initial import script #14

Closed pbaranay closed 7 years ago

pbaranay commented 7 years ago

Improves the speed of the initial import script by loading various objects into memory, rather than continually calling get_or_create.

Partially addresses #9.

codecov-io commented 7 years ago

Codecov Report

Merging #14 into master will increase coverage by 1.44%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   89.69%   91.14%   +1.44%     
==========================================
  Files           5        5              
  Lines         165      192      +27     
  Branches       19       29      +10     
==========================================
+ Hits          148      175      +27     
  Misses         14       14              
  Partials        3        3
Impacted Files Coverage Δ
src/magic_cards/utils/initial_import.py 94.23% <100%> (+2.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67590fe...f63633c. Read the comment docs.