search

pbaranay / django-magic-cards

A pluggable Django app for the Oracle text of all Magic: the Gathering cards
MIT License
7 stars 1 forks source link

Increse max_length of Card.name #5

Closed pbaranay closed 7 years ago

pbaranay commented 7 years ago

One card has a name that's 142 characters long, so max_length=127 is insufficient.

Since it's so early in the app's lifecycle, I've edited the initial migration in-place, rather than make a second migration.

Fixes #2.

codecov-io commented 7 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files           5        5           
  Lines         165      165           
  Branches       19       19           
=======================================
  Hits          148      148           
  Misses         14       14           
  Partials        3        3
Impacted Files Coverage Δ
src/magic_cards/migrations/0001_initial.py 100% <ø> (ø) :arrow_up:
src/magic_cards/models.py 83.63% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 377b4a4...1e130ff. Read the comment docs.