search

pbastowski / angular-meteor-babel

Babel 5 ES6 transpiler for angular-meteor (includes ng-annotate)
11 stars 4 forks source link

Babel Note about browser-polyfill-old.js #22

Closed mxab closed 8 years ago

mxab commented 8 years ago

When I build my program I get:

[BABEL] Note: The code generator has deoptimised the styling of "/packages/pbastowski_angular-babel/lib/browser-polyfill-old.js" as it exceeds the max of "100KB".

Not sure what it means and if it is ok :)

pbastowski commented 8 years ago

Two answers: 1) It's just an info message from Babel that can be safely ignored. 2) I will investigate why it mentions a "-old.js"

Thanks for reporting this.

pbastowski commented 8 years ago

@mxab I just published v1.3.3, which no longer shows the Babel Note.

Let me know if this helped.

mxab commented 8 years ago

hi, my build looks ok, the message is gone.

Unfortunately the build still takes about 10 mins but I guess it does not relate to this

Thanks

pbastowski commented 8 years ago

Thanks for checking.

wow, 10 mins. Was it also taking this long with Meteor 1.2?

mxab commented 8 years ago

I'm not 100% sure but I would say that it felt a bit faster, any ideas?

mxab commented 8 years ago

one thing i did with my 1.2 version was that I loaded a lot of libs like jquery, angular, angular-XXX via cdn maybe this had some effect on the minification process

pbastowski commented 8 years ago

Using CDNs would definitely have had an impact, because there would have been no need to minimise all those libraries. How many JS files do you have in your project?

mxab commented 8 years ago

about 450 js files

mxab commented 8 years ago

sorry thats wrong 450 html+js files

mxab commented 8 years ago

138 html 311 js 16 less