pbastowski / angular2-now

Angular 2 @Component syntax for Angular 1 apps
MIT License
145 stars 15 forks source link

Meteor 1.3.2.2 compatibility #55

Closed DmitryEfimenko closed 8 years ago

DmitryEfimenko commented 8 years ago

I think this got broken for Meteor 1.3.2.2. After updating meteor I started getting error: TypeError: Cannot read property 'init' of undefined on line 48 of compiled file.

} else {                                                             // 16
  angular2now.init();                                         // 17
} 
pbastowski commented 8 years ago

What version of Meteor were you using prior to 1.3.2.2?

Can you please post the rest of the file, so, I can see what else you are calling?

Or even better, provide me a link to a repo?

DmitryEfimenko commented 8 years ago

I think it was 1.3.1 before the update. I've added you as a collaborator to the project (it's private). The whole generated file is below:

//////////////////////////////////////////////////////////////////////////
//                                                                      //
// This is a generated file. You can view the original                  //
// source in your browser if your browser supports source maps.         //
// Source maps are supported by all recent versions of Chrome, Safari,  //
// and Firefox, and by Internet Explorer 11.                            //
//                                                                      //
//////////////////////////////////////////////////////////////////////////

(function () {

/* Imports */
var Meteor = Package.meteor.Meteor;
var global = Package.meteor.global;
var meteorEnv = Package.meteor.meteorEnv;
var meteorInstall = Package.modules.meteorInstall;
var Buffer = Package.modules.Buffer;
var process = Package.modules.process;

/* Package-scope variables */
var angular2now;

var require = meteorInstall({"node_modules":{"meteor":{"pbastowski:angular2-now":{"src":{"exports.js":function(){

///////////////////////////////////////////////////////////////////////
//                                                                   //
// packages/pbastowski_angular2-now/src/exports.js                   //
//                                                                   //
///////////////////////////////////////////////////////////////////////
                                                                     //
angular2now = this.angular2now;                                      // 1
                                                                     // 2
if (typeof System !== 'undefined' && System.register) {              // 3
  System.register('angular2now', [], function(_export) {             // 4
    for (var i in angular2now) {                                     // 5
      _export(i, angular2now[i]);                                    // 6
    }                                                                // 7
                                                                     // 8
    return {                                                         // 9
      setters: [],                                                   // 10
      execute: function() {                                          // 11
        angular2now.init();                                          // 12
      }                                                              // 13
    };                                                               // 14
  });                                                                // 15
} else {                                                             // 16
  angular2now.init();                                                // 17
}                                                                    // 18
                                                                     // 19
///////////////////////////////////////////////////////////////////////

}}}}}},{"extensions":[".js",".json"]});
require("./node_modules/meteor/pbastowski:angular2-now/src/exports.js");

/* Exports */
if (typeof Package === 'undefined') Package = {};
(function (pkg, symbols) {
  for (var s in symbols)
    (s in pkg) || (pkg[s] = symbols[s]);
})(Package['pbastowski:angular2-now'] = {}, {
  angular2now: angular2now
});

})();
pbastowski commented 8 years ago

The repo you supplied does not include angular2-now in it.

Were you trying to add angular2-now to your repo for the first time?

DmitryEfimenko commented 8 years ago

oh, my bad, I should have clarified. angular2-now is a dependency in another package: dotansimha:angular-reactive-component. It might be the case that they referenced it incorrectly, but it all used to work before. If you run the project, you'll see the errors I mentioned.

pbastowski commented 8 years ago

I upgraded to Meteor 1.3.2.2 and it's running fine for me right now, see below:

image

image

I'll push a new branch and perhaps it'll work for you too :)

pbastowski commented 8 years ago

Have a look at branch m1322.

DmitryEfimenko commented 8 years ago

Thanks, it looks like I messed up some local packages when I force updated them. I guess it's not a good thing to do. Thanks again for looking at it.

Sonatrix commented 7 years ago

my meteor up shows blank when open in IE11

pbastowski commented 7 years ago

@Sonatrix this issue is closed and you have provided no details at all.

I suggest you try ng2now instead of a gular2-now, which is a completely rewritten recent version of my library, available on npm.