search

pbatard / EfiFs

EFI FileSystem drivers
https://efi.akeo.ie
GNU General Public License v3.0
521 stars 79 forks source link

add LOONGARCH64 compilation support #43

Open MarsDoge opened 11 months ago

MarsDoge commented 11 months ago

This is a RISC processor architecture - LOONGARCH64, and the upstream EDK2 and GRUB repositories have merged related architecture patches, embracing open source ...

pbatard commented 11 months ago

Thanks for this.

The builds cannot run however because it appears that you committed the grub submodule after you applied the 0001-GRUB-fixes.patch, so you need to revert your changes to the grub submodules and update your pull request so that it can be validated for builds. Then you can re-apply the patch in your local repository.

pbatard commented 11 months ago

Hmmm, it looks like gcc-loongarch64-linux-gnu is not yet available for ubuntu-latest (the base images used by GitHub for Linux builds) per: https://github.com/pbatard/efifs/actions/runs/6770275752/job/18398546553?pr=43#step:2:20

I also don't think the gnu-efi compilation for LOONGARCH64 will work, since we can't update to a newer version of gnu-efi, and the ones we use has no biding for LOONGARCH64, so the linux_gcc_gnu-efi.yml GitHub actions file you modified is most likely bound to fail, even if gcc-loongarch64-linux-gnu is available.

I guess we can drop support for gnu-efi/LOONGARCH64, but obviously, since the binaries I publish are build through GitHub actions, we're going to have to wait until Ubuntu adds gcc-loongarch64-linux-gnu to their standard packages before we can add support for it in EfiFs. Right now, it seems like only binutils for LOONGARCH64 are available...

MarsDoge commented 11 months ago

Hmmm, it looks like gcc-loongarch64-linux-gnu is not yet available for ubuntu-latest (the base images used by GitHub for Linux builds) per: https://github.com/pbatard/efifs/actions/runs/6770275752/job/18398546553?pr=43#step:2:20

I also don't think the gnu-efi compilation for LOONGARCH64 will work, since we can't update to a newer version of gnu-efi, and the ones we use has no biding for LOONGARCH64, so the linux_gcc_gnu-efi.yml GitHub actions file you modified is most likely bound to fail, even if gcc-loongarch64-linux-gnu is available.

I guess we can drop support for gnu-efi/LOONGARCH64, but obviously, since the binaries I publish are build through GitHub actions, we're going to have to wait until Ubuntu adds gcc-loongarch64-linux-gnu to their standard packages before we can add support for it in EfiFs. Right now, it seems like only binutils for LOONGARCH64 are available...

Thank you very much for your reply. It is true that the latest ubuntu release version does not yet integrate the LoongArch compilation tool chain. Can I add efi support first?

MarsDoge commented 11 months ago

Looking forward to Ubuntu adds gcc-loongarch64-linux-gnu to their standard packages, I will request this PR again.