search

pbatard / Fido

A PowerShell script to download Windows or UEFI Shell ISOs
GNU General Public License v3.0
2.41k stars 228 forks source link

Improved code readability for P/Invoke #62

Closed farag2 closed 1 year ago

farag2 commented 1 year ago

Also it will be awseome if I you with a CI/CD config to automate the process of attaching archives to the release page. Also lzma cannot be opened via the File Explorer. The standard is zip. Share your thoughts please.

pbatard commented 1 year ago

I'll look at it, but please understand that in the context for which I actually develop Fido (which is pretty much exclusively for usage with Rufus), it might be a while, especially as I am going to have to validate that this doesn't break stuff on Windows 8 platforms.

The context is also the reason it's a .lzma, because, 1. it compresses better than zip and 2. this makes it easier to download from Rufus, which already has support for LZMA decompression. Also, 7-zip has no issue opening such files and, with the default compression support from Windows being years behind what it should be, I would really encourage people to use a much better handler, such as 7-zip, for compressed files.

In short, my actual goal with this project is definitely not the goal that you expect it to have, when it comes to being standalone or supporting bare Windows installations...

Still, I'll see what I can do with this PR.

farag2 commented 1 year ago

this doesn't break stuff on Windows 8 platforms

It won't. I just improved the readability, not the code. :) https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_splatting

pbatard commented 1 year ago

Sorry but I'll take testing over "trust me" when it comes to validating that a script that I provide to users does not introduce any regression/breakage...

farag2 commented 1 year ago

OK, no problem. But there's a tab with changes highlighted with green. :)