search

pbatard / libwdi

Windows Driver Installer library for USB devices
GNU General Public License v3.0
1.9k stars 466 forks source link

The mistake about Microsoft Extended Properties Feature Descriptor example #252

Closed MicroGrit closed 2 years ago

MicroGrit commented 2 years ago

In table 4 of the wiki page, the NUL-terminated Unicode String (LE) of Property name “DeviceInterfaceGUID” may be mistake. The unicode of "DeviceInterfaceGUID" is ['0x44', '0x65', '0x76', '0x69', '0x63', '0x65', '0x49', '0x6e', '0x74', '0x65', '0x72', '0x66', '0x61', '0x63', '0x65', '0x47', '0x55', '0x49', '0x44']. So, the example of NUL-terminated Unicode String (LE) should as follows:

0x44, 0x00, 0x65, 0x00,
(...)
0x44 0x00, 0x00, 0x00		 NUL-terminated Unicode String (LE) Property name"DeviceInterfaceGUID"

Original example is:

0x44, 0x00, 0x65, 0x00,
(...)
0x74 0x00, 0x00, 0x00		 NUL-terminated Unicode String (LE) Property name"DeviceInterfaceGUID"

The original 0x74 should be modified to 0x44.

Ambiguous examples may lead to misunderstandings for developers. If what I describe makes sense, please update the wiki page. In addition, If my above description is wrong, please let me know why.

Looking forward to your reply! Thanks!

pbatard commented 2 years ago

Yeah, that was a typo. This is fixed now. Thanks for reporting it.