search

pbatard / libwdi

Windows Driver Installer library for USB devices
GNU General Public License v3.0
1.9k stars 466 forks source link

Update autogen.sh #291

Closed sl1200mk2 closed 1 year ago

sl1200mk2 commented 1 year ago

Hi, I had difficulties to compile libwdi (using sh autogen.sh) unless I remove: --with-libusb0="D:/libusb-win32" --with-libusbk="D:/libusbK/bin"

best regards, nicolas

pbatard commented 1 year ago

Sorry but on this project, autogen.sh is meant for internal use only (hence the hardcoded paths, including the one for Windows Kits, which should be removed as well if you want to be comprehensive with your PR), so I am not planning to alter it.

For the record, that autogen.sh also recreates the .def files, which no regular user should have to do either.

You're supposed to use bootstrap.sh and then configure.

And I kind of guess you're going to want to reply that autogen.sh should be renamed to something else if it's meant to be internal, but for a small project like libwdi, I don't see how it's worth the trouble.

I will therefore close this PR.

sl1200mk2 commented 1 year ago

ahhh ok Pete, thank you for the tip

++